Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out where URIs should come from #25

Open
moonglum opened this issue Jan 4, 2019 · 0 comments
Open

Figure out where URIs should come from #25

moonglum opened this issue Jan 4, 2019 · 0 comments

Comments

@moonglum
Copy link
Member

moonglum commented Jan 4, 2019

Where are URIs being generated now? I've noticed Navigation concatenates baseURI and slug, so the lack of encapsulation makes me uncomfortable once more (based on actual real-world experience).

Having said that: It's probably not important right now; we'll deal with it if and when it comes up during actual use.

aiur's entry point (i.e. index.js) passes baseURI (optional?¹ configuration) to Site which in turn passes it through to Navigation in order to make it available to Navigation#item. It looks like that method is the only place where baseURI is actually being used, so the entire pass-through dance seems smelly. On the upside, that should make it relatively straightforward to restore encapsulation.²

¹ Looks like cli.js sets a default - though that seems odd; such global defaults should be defined by whichever module assumes primary responsibility for the respective value (cf. prior faucet discussions in that vein).

² Site should probably assume responsibility for URIs; cf. ac689aa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant