Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for ×× and ×...× passages #22

Open
gerritbruening opened this issue Dec 15, 2016 · 3 comments
Open

Tooltip for ×× and ×...× passages #22

gerritbruening opened this issue Dec 15, 2016 · 3 comments

Comments

@gerritbruening
Copy link

gerritbruening commented Dec 15, 2016

Corresponding to the tooltip in the textual rendering, "(ungefähr) ... unlesbare Zeichen".

See https://faustedition.uni-wuerzburg.de/wiki/index.php/Feedback_zur_Beta_1#Seminar_Goethes_Faust:_Entstehung_und_Edition

Test case:

@gerritbruening gerritbruening changed the title Tooltip for ×...× passages Tooltip for ×× and ×...× passages Dec 15, 2016
@wissenbach wissenbach self-assigned this Mar 10, 2017
@wissenbach
Copy link
Member

fixed by 0d7eb8a

@wissenbach
Copy link
Member

Tooltip is visible, but there is no explicit "unreadable" information displayed, so I'm reopening the bug.

@wissenbach wissenbach reopened this May 5, 2017
@wissenbach wissenbach removed their assignment May 5, 2017
@thvitt
Copy link
Member

thvitt commented May 11, 2017

Chris' tooltip generation code creates the tooltip HTML from the class attributes of children of g.text-wrapper.

This is how the unclear information shows up in the SVG (from the test case above):

<g class="element-unclear unclear-cert-high" transform="matrix(1, 0, 0, 1, 18, 0)">
  <g class="text-wrapper" transform="matrix(1, 0, 0, 1, 0, 0)">
    <rect class="bgBox hand-g material-t normal" x="0" y="-16" height="21" width="10"/>
    <text class="text hand-g material-t normal">{</text>
  </g>
  <g class="text-wrapper" transform="matrix(1, 0, 0, 1, 5, 0)">
    <rect class="bgBox hand-g material-t normal" x="0" y="-16" height="21" width="60"/>
    <text class="text hand-g material-t normal">unclear</text>
  </g>
  <g class="text-wrapper" transform="matrix(1, 0, 0, 1, 53, 0)">
    <rect class="bgBox hand-g material-t normal" x="-1" y="-16" height="21" width="11"/>
    <text class="text hand-g material-t normal">}</text>
  </g>
</g>

so we'll probably need adjustments to look at ancestors of the .text-wrapper, as well

thvitt added a commit that referenced this issue Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants