-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more motivational quotes #3
Comments
@rahulshawdev You did a PR #5 with 3 commits. Are you interested in having that PR contributing to the hacktoberfest? I can wait for October if you want but assigning the issue to you. Anyway, the commit #bc49516 and #73355dd are valid but #0a58b09 not because you modified all the text (you changed the quotes, among a few other things). Remember also that the last quote ALWAYS goes without the comma at the end |
Yup, I'm interested in contributing to hacktoberfest. |
I didn't modify all the text, when I click to save on my VS Code, all the thingsautomatically formatted by Prettier. Can you tell me how can I solve that problem?? |
Okay, I'll assign it to you. I'll wait for your final PR in October. If there is no update in mid-October, I will designate it for you so that someone else can participate
I do not know the extension you are talking about but the easiest thing would be to copy and paste all the phrases directly without going through the code editor |
I fix it |
You didn't pushed it or updated the PR |
I will do it. You merge my PR. I will make another one. |
You told me reserve it for Hacktoberfest. I would wait October then. Whatever, I'll do more issues like this, if nobody take them, is all yours |
Any news? @rahulshawdev |
7 days to finish Hacktoberfest, bro. Any news? @rahulshawdev #5 |
Nah bro. Merge it |
How? I can't merge it, you got conflicts. Please read this |
You can add more motivational quotes adding it to the array on background.js
Clarification: If this issue is assigned to a person, don't worry. I'll make more issues like this. Just please be aware and check all sentences before writing. There should be no repeating phrase as the randomness factor would be lost.
The text was updated successfully, but these errors were encountered: