Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD frases english spanish - ADD button Spanish #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devjaime
Copy link

@devjaime devjaime commented Oct 4, 2021

Hello everyone, I hope this PR meets the requirements

ADD frases english spanish - ADD button Spanish

Thanks

@fcoterroba
Copy link
Owner

Hey! @devjaime We're talking about this on #8 , do you think the best option will be make as many arrays as languages? It would be separated in JSONs to keep the perfomance? We should maybe use a translator api?

@Harsh-Singh-Rajput
Copy link
Contributor

Hey! @devjaime We're talking about this on #8 , do you think the best option will be make as many arrays as languages? It would be separated in JSONs to keep the perfomance? We should maybe use a translator api?

API will be good to use

@devjaime
Copy link
Author

devjaime commented Oct 4, 2021

hello everyone, if you think it better to translate automatically with an API, it may be more efficient to read the code, but for the user who reads the motivational messages, it may not be the best option.
What if it seems to me that it could be a single button that detects the language of the browser and displays the correct language?.

@fcoterroba
Copy link
Owner

hello everyone, if you think it better to translate automatically with an API, it may be more efficient to read the code, but for the user who reads the motivational messages, it may not be the best option. What if it seems to me that it could be a single button that detects the language of the browser and displays the correct language?.

Yeah, you got reason in that way, use an API is more efficient to the code but worse to the user so, we need to find the middle.

Should we make many JSON as languages registered? And, in the case which the language isn't registered as JSON? Show it in English? That's won't be unefficient for the program?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants