Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQueryOfflineStoreConfig throws error when billing_project_id is present #4678

Open
Prathap-P opened this issue Oct 24, 2024 · 1 comment

Comments

@Prathap-P
Copy link

Prathap-P commented Oct 24, 2024

Expected Behavior

Should be able to use bigquery as offline with billing_project_id

Current Behavior

Not able to intialize feast with bigquery as offfline, got the following error

Screenshot 2024-10-24 at 10 22 54 AM

Steps to reproduce

Instantiate feast with bigquery as offline and add billing project id.

Specifications

  • Version: 0.40, 0.37
  • Platform: Mac (M1)

Possible Solution

With pydantic 2.9.2 values dict inside field_validator has data atrribute which has all the required details like project_id, billing_project_id, but when going through codebase in sdk/python/feast/infra/offline_stores/bigquery.py at line 107 found that project_id is expected inside values dict

@boumelhaa
Copy link

this is a pydantic issue that is faced when moving to pydantic 2.x

it should be something like this

       def project_id_exists(cls, v, values, **kwargs):
          if v and not values.data.get("project_id"):
              raise ValueError(
                  "please specify project_id if billing_project_id is specified"
              )
        return v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants