Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize get_online_features by consolidating calls to online store across multiple feature views #4711

Open
breno-costa opened this issue Oct 28, 2024 · 2 comments
Labels
kind/feature New feature or request

Comments

@breno-costa
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'm running some benchmarks to measure Python SDK performance and want to discuss a potential improvement on get_online_features implementation.

When using the get_online_features method in the SDK with a Redis online store, performance suffers when handling a feature service that includes multiple feature views. The SDK iterates over each feature view within the feature service and calls online_store.online_read(...) for each view individually.

Although the Redis online store implementation uses Redis pipeline to reduce network roundtrips, the current SDK implementation separates pipeline calls per feature view, leading to inefficiencies that impact overall performance.

Describe the solution you'd like
I think online store interface should have a method to get online features by a list of feature views (or a feature service), and the get_online_features should be changed accordingly.

Additional context
Feast's Java code follows a different implementation. It combines features that share same entity keys before calling online store.

@breno-costa breno-costa added the kind/feature New feature or request label Oct 28, 2024
@franciscojavierarceo
Copy link
Member

Yeah this makes sense. Would be supportive of this.

@tokoko
Copy link
Collaborator

tokoko commented Nov 2, 2024

I think online store interface should have a method to get online features by a list of feature views

This is sort of already the case, isn't it? The main reason why get_online_features method (and the default logic) was moved from feature_store.py to online_store.py was to make this possible. Before then online_read was the only OnlineStore method that individual implementations could override.

I guess we can have yet another method sitting somewhere between online_read and get_online_features, but I think the best way to discern how that method should look like would be to first rewrite one online store (for example redis) to override get_online_features instead of online_read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants