Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables Filters Text Sizes/Styles #6624

Open
rfultz opened this issue Jan 7, 2025 · 1 comment
Open

Datatables Filters Text Sizes/Styles #6624

rfultz opened this issue Jan 7, 2025 · 1 comment

Comments

@rfultz
Copy link
Contributor

rfultz commented Jan 7, 2025

Does it bother anyone else that the text in filters panel is inconsistent when scrolling? Individually, they make sense; collectively they feel just different enough to be distracting.

In the screenshot, some things that stand out to me:

  • The text under 'DATA TYPE' is smaller than the text in the rest of the column.
  • The 'State or Territory' and 'Occupation' text line-height is smaller than 'DATA TYPE' or 'Time Period'
  • The space between 'Time Period' and 'When searching accross[sic]' is too large and doesn't match the rest
  • 'Across' should only have one c
  • I personally don't like the periods at the end of any of these explainers but it feels inconsistent, especially at the end of Occupation where we've been using a sentence (with a period) but end with a limit disclaimer (without a period). I'd want to check into how screen readers and spiders handle them (i.e. whether they read them as a big blob of text or if they separate them according to the semantic structure)

Image

@JonellaCulmer
Copy link
Contributor

Some of this work may be handled in the state/territory filter ticket: #6490

@JonellaCulmer JonellaCulmer moved this from 🔨 Pre-refinement to 🔜 Sprint backlog in Website project Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔜 Sprint backlog
Development

No branches or pull requests

2 participants