Go to definition -> no definition found #225

TypedSource · 2017-12-07T10:09:07Z

i installed php-intellisense in the morning, disabled php.suggest.basic, set php.executablePath and opened my php project folder (inserted into workspace).

if i want to go to a definition of a class or function or var i allways get a message that no definition is available.

http://prntscr.com/hk8x14

the project was written in intelliJ and all works fine there. a change to vscode without correct working php intellisense is senseless.

The text was updated successfully, but these errors were encountered:

sunverwerth · 2017-12-07T12:49:46Z

Do you see any errors under "Help" > "Developer Tools"

TypedSource · 2017-12-07T14:11:41Z

No, there is no error in the console and no error in the network tab. looks all fine.

nothing is triggered in the logs on trying to jump to definition

rquispeq · 2017-12-24T15:40:56Z

I have the same problem too, those options only work if i want a definition in the current file

TypedSource · 2018-01-15T08:25:05Z

no sollution for it? i think vscode is going to be useless for me as php coder under windows now and i switch back to intelliJ or Atom

pacobyte · 2018-01-22T15:01:12Z

Go to Definition is the first feature of this extension that I tried. Instead of getting an error, the "progressbar" just keeps moving across the screen as if it's constantly trying.

Does Go to Definition work for anyone? Or is there something specifically wrong with our installations?

iEns · 2018-02-02T17:35:12Z

I have the same problem.

I can only go to a definition in the same file.
If I open the file containing the definition, I can now go to the definition.
If I close the file containing the definition again, I can still go to the definition.
After restart of VS Code I am back to step 1.

Any way of forcing a scan or indexing of the workspace?

(I'm on MacOS 10.13.3)

[Edit] No errors listed in Developer Tools console.

cha0s · 2018-02-25T23:51:42Z

Same. Go to definition only works for definitions that exist in already-opened files. This makes closing and reopening a PHP project extremely painful.

rquispeq · 2018-02-28T03:00:08Z

Hi, I remember that i coudn't fix this problem, but then i found a extension called Codeiginiter Intelliphense or something, and it has those options too. Of course, it only works if you have the framework. It could help somebody :)

benyaminl · 2018-05-02T08:35:01Z

Does anyone here have try to reset the php.exe? Sometimes the php.exe isn't working and need to be killed.

minkmk94 · 2018-05-17T07:16:12Z

I have same problem, i need this feature like "Go to definition" of Sublime text 3

wagnerjsilva · 2018-05-18T10:39:13Z

I definitely need to be able to go to definition as a PHP developer.
Shame, I really liked vs code, but this is an essential feature.

torykepler · 2018-05-22T15:22:05Z

As others have mentioned, 'Go to definition' only seems to work if you have already opened the file where the definition is located. Does anyone have a solution for this?

benyaminl · 2018-05-22T16:05:20Z

I never experienced it. Hmmm... Sent from My Asus Pegasus X005 Pada tanggal Sel, 22 Mei 2018 22.22, Tory Kepler <[email protected]> menulis:

…

As others have mentioned, 'Go to definition' only seems to work if you have already opened the file where the definition is located. Does anyone have a solution for this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#225 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACr9NHJlvQg3c-kAExlRweycDatWKSPlks5t1C0lgaJpZM4Q5SxE> .

JoffreyPoreeCoding · 2018-05-25T15:26:37Z

Same issue here...

tposcic · 2018-05-29T08:28:55Z

Same issue here. Quite a pain in the ass

sunverwerth · 2018-05-29T12:31:04Z

Can anybody give more information? It works fine for me.

Extension version? Operating system? PHP Version? How many source files?

Valera1980 · 2018-06-05T13:24:09Z

go to definition not working

win 7 sp1

danielhuang-030 · 2018-07-31T03:47:13Z

not working for me too, my info:

OS: WINDOWS 10 Home
VS Code ver
VS Code ext
VS Code user settings
function undefined

benyaminl · 2018-08-01T02:49:58Z

@danielhuang-030 When you tried the autocomplete does the autocomplete work? If not than don't expect that the goto function would work. I suggest to try https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client I don't advertise it, but for now that's a alternative that works very good and not depends on php.exe

vasilestefirta · 2018-09-10T05:25:39Z

Any updates on this issue? I have the same problem! This is probably the most important feature everyone is looking for and there has to be a solution to solve the current problem.

VS Code - version 1.27.1
PHP IntelliSense - version 2.3.5
PHP 7.1.16
Mac OS High Sierra - version 10.13.6

---- UPDATE ----
Actually I think it works it some use-cases and it doesn't it some different use-cases. For example, I have this code from a Laravel project:

    /**
     * Show details for a given listing
     *
     * @param  \App\Area   $area
     * @param  \App\Listing   $listing
     *
     * @return \Illuminate\Http\Response
     */
    public function show(Area $area, Listing $listing)
    {
        if (! $listing->live()) {
            abort(404);
        }

        if (auth()->check()) {
            auth()->user()->viewedListing($listing);
        }

        return view('listings.show', compact('listing'));
    }

I was able to get the Go To Definition to work for the live() method, but not for viewedListing() method.

felixfbecker · 2018-09-10T13:31:27Z

@benyaminl you already mentioned this before in the thread. Please keep this issue on topic.

To everyone else: If there is no update posted on this issue, there is no update. I don't have the capacity to investigate this in my free time. If anyone wants to do a PR with a fix, I am willing to invest time to review it. Given the amount of people here that posted here that they are affected by this, one would think someone here would care enough to look into it. It's just PHP code 🙂

benyaminl · 2018-09-10T13:34:18Z

@felixfbecker I think it's time for you to set up patreon profile so it would be your side project that generate money ✌️ so you have more time for develop it because it generate money :v

Koekoe · 2018-09-14T10:10:49Z

On MacOS, when a folder is a symlink to another folder the content is not indexed, thus some definitions are not working. Could this be the problem ?

cha0s · 2018-09-15T15:54:27Z

The problem is that by default this extension doesn't scan all files. You have to do hax like patching the source, or making sure the first directory in your workspace is an aggregate of any other directories in your workspace (defeating the purpose of having them broken down cleanly in the first place).

The solution is to make the scan directories configurable, but I haven't written a patch for it yet.

maslade · 2018-11-21T15:36:42Z

@cha0s This was it for me, and I'm curious how many others in this thread are in similar situations. I had two folders: a project folder (mostly text files and assets) and a library folder (PHP). "Go to Definition" only worked when the file containing the definition was already opened.

I then removed the project folder, so I only had the PHP folder, and now can navigate to those definitions even when the file is closed.

And for anyone wondering - I added the project folder back so that it was second on the list, and Intellisense still worked happily after a fresh restart. So it appears from behavior like the defect here is that the plugin only looks at the first directory in the list.

moonbas3 · 2019-01-18T16:42:51Z

Works for me as well if the first folder in the project is the one including all the other code. Thanks for the tip.

vushe · 2019-02-08T07:36:43Z

Works for me as well if the first folder in the project is the one including all the other code. Thanks for the tip.

Nope. Just endless scanning in my case... Find all references does not work too.

ThomasK0lasa · 2019-02-08T08:57:52Z

Same for me - the go to definition doesn't work in case of Joomla larg projects.

Bashitha · 2019-02-19T07:32:22Z

Same for me. Go to definition doesn't seem to be working specially when calling functions. I am using PHP in Visual Studio Code. OS is ubuntu. Auto complete is working fine. I installed PHP intelephense 0.8.8 extension. But still not working. Any updates on this issue?

benyaminl · 2019-02-19T07:33:36Z

Same for me. Go to definition doesn't seem to be working specially when calling functions. I am using PHP in Visual Studio Code. OS is ubuntu. Auto complete is working fine. I installed PHP intelephense 0.8.8 extension. But still not working. Any updates on this issue?

Hello please it's Intelisense project repository. Intelephense Project repository is on https://github.com/bmewburn/intelephense/issues

Bashitha · 2019-02-19T17:47:13Z

Same for me. Go to definition doesn't seem to be working specially when calling functions. I am using PHP in Visual Studio Code. OS is ubuntu. Auto complete is working fine. I installed PHP intelephense 0.8.8 extension. But still not working. Any updates on this issue?

Hello please it's Intelisense project repository. Intelephense Project repository is on https://github.com/bmewburn/intelephense/issues

Hello @benyaminl Tried with Intellisense extension also. But not functioning the go to definition for function calls. Just showed as loading without directing to the definition location.

benyaminl · 2019-02-20T03:03:10Z

Same for me. Go to definition doesn't seem to be working specially when calling functions. I am using PHP in Visual Studio Code. OS is ubuntu. Auto complete is working fine. I installed PHP intelephense 0.8.8 extension. But still not working. Any updates on this issue?

Hello please it's Intelisense project repository. Intelephense Project repository is on https://github.com/bmewburn/intelephense/issues

Hello @benyaminl Tried with Intellisense extension also. But not functioning the go to definition for function calls. Just showed as loading without directing to the definition location.

If it's joomla seems there's some problem that you should know. Joomla code sometimes not follow the PSR standard and it's sequential in some way, that need special plugin for it. I also experience it with Laravel where the routing and other object not working and their code some follow the rule some not, Also Dolibarr ERP(based on PHP). You can't ask the universal tools to support code that's aren't standard. Sorry.

ThomasK0lasa · 2019-02-20T06:58:33Z

@benyaminl thank You for that information. :)
I am thinking about moving to PHP Storm because everything works fine in it. But I like the VSC. :(
I have same problem with Intelephense and Intelisense in case of Joomla and VSC. I am still thinking that maybe I have some missconfiguration.

benyaminl · 2019-02-20T07:01:13Z

@benyaminl thank You for that information. :)
I am thinking about moving to PHP Storm because everything works fine in it. But I like the VSC. :(
I have same problem with Intelephense and Intelisense in case of Joomla and VSC. I am still thinking that maybe I have some missconfiguration.

Not everything working in PHP Strom, Dolibarr isn't supported on both of editor, and only class, variable and such that's follow the PSR standard that's indexed. So for me it's normal for VS Code. PHP Strom is too heavy and not power friendly

benyaminl · 2019-02-21T07:49:15Z

Same for me. Go to definition doesn't seem to be working specially when calling functions. I am using PHP in Visual Studio Code. OS is ubuntu. Auto complete is working fine. I installed PHP intelephense 0.8.8 extension. But still not working. Any updates on this issue?

Hello please it's Intelisense project repository. Intelephense Project repository is on https://github.com/bmewburn/intelephense/issues

You've mentioned it three times already, whereas one time would be more than enough. Do you want to start discussing here bugs of PHP Intelliphense too? Politeness is highly appreciated.

I don't talk about intelephense bug, but many people refer it too much. I think I just refer them to it and stop talking OOT, sorry if it's seems so pushy, but it's intelisense project and not for other extension mater. That's why I remind them.

dgloriaweb · 2019-07-20T04:50:52Z

Hi, I use vscode with a codeigniter php project, and I'm making a simple model-controller stuff using CI as base, but the $this->post_model->get_posts(); isn't picking up the get_posts from the method. I also work on a huge project at work, where this would be essential, and it's quite frustrating, because I used to use phpstorm and it worked like charm.

karensrapyan · 2021-01-04T09:50:08Z

I see that in https://intelephense.com/ they are selling that option.
Open source VS Code:)

yehudaTiram · 2021-06-22T13:09:55Z

For me the issue was that vs code was using php v7.0.3
To fix it:
Go to ~\AppData\Roaming\Code\User\settings.json (Windows 10)
OR
Click F1 to open Command palette
search and select "Preferences: Open settings (UI)
search for "php.validate.executablePath"
Click edit in settings.json
in the json file change the path to the latest php version in your machin.

(for me it is "php.validate.executablePath": "C:/wamp64/bin/php/php7.4.0/php.exe",)

szczemp · 2023-05-09T16:13:29Z

I have similar problem. And with separate functions with the same name. Eg: myCustomFunction() in adminInclude.php file and myCustomFunction() in indexInclude.php. adminInclude.php file is included in admin.php and there I use myCustomFunction(). indexInclude.php is included in index.php and there I use myCustomFunction() too. Go To Definition shold find definions in both files, but there is only one sometimes from adminInclude.php someitmes from indexInclude.php.

szczemp · 2023-05-12T16:13:34Z

I have similar problem. And with separate functions with the same name. Eg: myCustomFunction() in adminInclude.php file and myCustomFunction() in indexInclude.php. adminInclude.php file is included in admin.php and there I use myCustomFunction(). indexInclude.php is included in index.php and there I use myCustomFunction() too. Go To Definition shold find definions in both files, but there is only one sometimes from adminInclude.php someitmes from indexInclude.php.

I think I found a solution. I installed the extension: https://marketplace.visualstudio.com/items?itemName=DEVSENSE.phptools-vscode Go To Definition works fine.

This comment has been minimized.

Sign in to view

Go to definition -> no definition found #225

Go to definition -> no definition found #225

Comments

TypedSource commented Dec 7, 2017 • edited Loading

sunverwerth commented Dec 7, 2017

TypedSource commented Dec 7, 2017 • edited Loading

rquispeq commented Dec 24, 2017

TypedSource commented Jan 15, 2018

pacobyte commented Jan 22, 2018

iEns commented Feb 2, 2018 • edited Loading

cha0s commented Feb 25, 2018

rquispeq commented Feb 28, 2018

benyaminl commented May 2, 2018

minkmk94 commented May 17, 2018

wagnerjsilva commented May 18, 2018

torykepler commented May 22, 2018

benyaminl commented May 22, 2018 via email

JoffreyPoreeCoding commented May 25, 2018

tposcic commented May 29, 2018

sunverwerth commented May 29, 2018

Valera1980 commented Jun 5, 2018 • edited Loading

danielhuang-030 commented Jul 31, 2018

benyaminl commented Aug 1, 2018

This comment has been minimized.

vasilestefirta commented Sep 10, 2018 • edited Loading

This comment has been minimized.

felixfbecker commented Sep 10, 2018

benyaminl commented Sep 10, 2018 • edited Loading

This comment has been minimized.

Koekoe commented Sep 14, 2018

cha0s commented Sep 15, 2018

maslade commented Nov 21, 2018

moonbas3 commented Jan 18, 2019

vushe commented Feb 8, 2019

ThomasK0lasa commented Feb 8, 2019

Bashitha commented Feb 19, 2019

benyaminl commented Feb 19, 2019

Bashitha commented Feb 19, 2019 • edited Loading

benyaminl commented Feb 20, 2019

ThomasK0lasa commented Feb 20, 2019

benyaminl commented Feb 20, 2019

benyaminl commented Feb 21, 2019

dgloriaweb commented Jul 20, 2019

karensrapyan commented Jan 4, 2021

yehudaTiram commented Jun 22, 2021

szczemp commented May 9, 2023

szczemp commented May 12, 2023

TypedSource commented Dec 7, 2017 •

edited

Loading

TypedSource commented Dec 7, 2017 •

edited

Loading

iEns commented Feb 2, 2018 •

edited

Loading

Valera1980 commented Jun 5, 2018 •

edited

Loading

vasilestefirta commented Sep 10, 2018 •

edited

Loading

benyaminl commented Sep 10, 2018 •

edited

Loading

Bashitha commented Feb 19, 2019 •

edited

Loading