Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Better UI for crypto instant app #242

Open
sahil-shubham opened this issue Nov 30, 2021 · 10 comments
Open

Better UI for crypto instant app #242

sahil-shubham opened this issue Nov 30, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers miscellaneous An issue which does not fit any of the issue templates

Comments

@sahil-shubham
Copy link
Contributor

Issue

The current crypto app can be improved in terms of UI.
image

suggestions

  • we can show the time at which the shown rates were fetched
  • we can show candlesticks or charts to get a better understanding of rise and dip
  • ....
@sahil-shubham sahil-shubham added enhancement New feature or request miscellaneous An issue which does not fit any of the issue templates good first issue Good for newcomers labels Nov 30, 2021
@Reza9472
Copy link

Reza9472 commented Dec 1, 2021

Hey can I work on this?

@sahil-shubham
Copy link
Contributor Author

Sure, go ahead @Reza9472. Let me know if you face issues with implementation or have any other ideas to discuss.

Assigning this to you.

@Reza9472
Copy link

Reza9472 commented Dec 2, 2021

Hey are you set on using Messari.io as your API or can I change it?

@sahil-shubham
Copy link
Contributor Author

We can change it any other alternatives if they are better. Which ones do you have in mind?

@Reza9472
Copy link

Reza9472 commented Dec 3, 2021

I actually found the documentation of Messari a bit all over the place. I'm trying a bunch of options.
Just wanted to see if you are open to change.
I'll let you know if I pick one and we can discuss if that works for you or not👍🏻

@Reza9472
Copy link

Reza9472 commented Dec 8, 2021

@sahil-shubham Hey can you help me with this question? #262

@Reza9472
Copy link

Reza9472 commented Dec 9, 2021

@sahil-shubham Hey just a quick peek at what I am doing.
what do you think about this chart?

It's not finished and still gotta fix some stuff but this is how it looks like

Screen Shot 2021-12-09 at 1 27 07 PM

@sahil-shubham
Copy link
Contributor Author

Looks good, you can make a WIP (work in progress) pull request I can comment on the code better. No need to wait for finished code to make a PR. What do you think?

@Reza9472
Copy link

Reza9472 commented Dec 9, 2021

Sure. I'll clean it up and send the PR as soon as I can

@sahil-shubham
Copy link
Contributor Author

Sounds great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers miscellaneous An issue which does not fit any of the issue templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants