Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request(?): open popup in center of window #3

Open
Pi2048 opened this issue Jun 27, 2022 · 3 comments
Open

Feature request(?): open popup in center of window #3

Pi2048 opened this issue Jun 27, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Pi2048
Copy link

Pi2048 commented Jun 27, 2022

When I call BibtexciteShowCite, the popup appears down and right from the cursor location. That works well enough when the cursor is in the top left of the window, but it it's at the right edge, the showcite-popup is narrowed so much that it becomes unreadable.

I've changed the call to popup_create by removing the two lines at https://github.com/ferdinandyb/bibtexcite.vim/blob/master/autoload/bibtexcite/floating_preview.vim#L175-L176. The popup now always shows up in the middle of my window, which is always readable.

@ferdinandyb
Copy link
Owner

That does sound much better! Can you make a pull request with that?

@ferdinandyb
Copy link
Owner

ferdinandyb commented Jun 28, 2022

I actually did it just now, but for vim only. I still need to figure that out for nvim.

@Pi2048
Copy link
Author

Pi2048 commented Jun 29, 2022

Great, thanks! I'm not an nvim user, so I can't help you out with that part of the code.

@ferdinandyb ferdinandyb self-assigned this Jul 24, 2023
@ferdinandyb ferdinandyb added the bug Something isn't working label Jul 24, 2023
@ferdinandyb ferdinandyb added this to the 1.0 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants