Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero fill to make abstract-chunk-store compliant #1

Open
ghost opened this issue Feb 10, 2016 · 0 comments
Open

zero fill to make abstract-chunk-store compliant #1

ghost opened this issue Feb 10, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 10, 2016

I think zeroPadding: false violates the expectations of the abstract-chunk-store test suite: https://github.com/mafintosh/abstract-chunk-store/blob/master/tests/index.js#L25-L34

With zeroPadding: false, chunks are written to the store that are smaller than the chunkLength, which according to the abstract-chunk-store tests should result in an error.

@ghost ghost mentioned this issue Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants