Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload config on change #114

Open
Sweattypalms opened this issue Nov 2, 2024 · 8 comments
Open

Reload config on change #114

Sweattypalms opened this issue Nov 2, 2024 · 8 comments

Comments

@Sweattypalms
Copy link
Member

Instead of loading once at startup, make it so it automatically reloads the static variable when the file changes. Perhaps with file watcher or something?

@Sweattypalms Sweattypalms converted this from a draft issue Nov 2, 2024
@0xnim
Copy link
Contributor

0xnim commented Nov 2, 2024

Maybe not dynamically but with a /reload

@Skullians
Copy link
Contributor

When we get a command api that's a possibility
but bearing in mind not a lot of the reloaded configs will apply until restart
sure, motd but not much else

@0xnim
Copy link
Contributor

0xnim commented Nov 2, 2024

online-mode should not be able to change

@Sweattypalms
Copy link
Member Author

wouldn't a file watcher be convenient?

@0xnim
Copy link
Contributor

0xnim commented Nov 2, 2024

Default config values would be overwritten by api anyways. So watcher would create conflicts

@GStudiosX2
Copy link

GStudiosX2 commented Nov 3, 2024

I don't see a use for this there's not many options in the config that can actually be reloaded

@0xnim
Copy link
Contributor

0xnim commented Nov 3, 2024

close this issue?

@GStudiosX2
Copy link

GStudiosX2 commented Nov 4, 2024

close this issue?

I mean once ferrumc gets bigger and there's more configuration stuff perhaps this could be something.

I think most would rarely change the config after they set it up how they like it the server starts up fast anyways 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

4 participants