Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please republish to Forge, current module fails to install - incorrect metadata #89

Open
canihavethisone opened this issue Oct 10, 2021 · 3 comments

Comments

@canihavethisone
Copy link
Contributor

The module on the forge is not current with what is here on Github, despite the version being the same in metadata.

Also the version on the forge fails to install as the dependency for nftables is incorrect, referencing puppetlabs instead of puppet (vox pupuli). The version is also too low, with an upper limit of <2.0.0 (it is now at v2.1.0)

Can you please update the metadata as below and publish the current github copy to the forge?

{ "name": "puppet/nftables", "version_requirement": ">= 2.0.0 < 3.0.0" },

@canihavethisone canihavethisone changed the title Forge module fails to install - incorrect metadata Please republish to Forge, current module fails to install - incorrect metadata Oct 13, 2021
@garyttt
Copy link
Contributor

garyttt commented Oct 20, 2021

Hi all, for those who are interested, I have managed to write my own utility scripts to resolve many issues including typo, mismatch, dependencies and so on... You may check-out https://github.com/garyttt/cis_profile, and implemented it with PE 2021.3 and Foreman 3.0.

@canihavethisone
Copy link
Contributor Author

@garyttt thanks for that, looks interesting. Have you considered creating a pull request here with those changes? I am wondering if this module should be forked and republished as it seems to be somewhat neglected and doesn't install from the copy available on the puppet forge at present.

@garyttt
Copy link
Contributor

garyttt commented Oct 25, 2021

@canihavethisone I did (PR#85 and PR#86 here), however not all changes were accepted, as there were some complexity changing the old style for the rules, using numbering wording or using 'ensure_xxx' wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants