-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate nodes in meshviewer output #8
Comments
More information: |
I can see this behaviour in the Dortmund Community too. I reverse engineered the specification for the graph.json, since I couldn't find a formal specification. Is there a good document on how to assemble the graph.json correctly?
Currently I don't know how to handle this differently. |
ffnord/ffmap-backend#70 |
there isn't a node id for every mac EDIT: I got it: They are linked by order. Every unlinked mac belongs to the last mentioned node id. |
So a viable solution would to just include the first BATMAN mesh MAC in the node list? |
That won't work |
Please do. The whole meshviewer stuff is badly documented and needs to be retired as well (alongside ffmap-backend). So I would like to implement sufficient support for this as easy as possible and then put energy (together with others) into better solutions. |
The best thing would also be to read the nodeinfo details once they are needed to reduce load times and datq |
Exactly. The current approach won't work for larger communities or overview maps. |
So this is the structure you need:
|
Is that sufficient for you to fix this? |
I hope so, have to test it. |
@plumpudding I hope that this issue is resolved now. I added an unit test, which tests for this structure now. But nothing better than a real world test :) Especially against for undocumented formats. |
I give up.. It's better already. The nodes aren't duplicate, but MoL connections don't show up. When I compared it to an original json, I noticed that my offloader has only one mac linked to it, but it (if my structure is right that is) and it still has a vpn and a MoL connection. On the gluon-collector json it has 3 macs, but not a single connection in the meshviewer. |
New approach: |
If you don't mind I'll try to do this. It will result in some ugliness though. |
Please do, I can review a pull request. But since the format meshviewer uses is much worse than initially thought and one of my goals is to move to more sane formats, I don't want to invest too much time in such legacy formats. |
EDIT: YAAY it's doin something: |
http://gl.wupper.ffrl.de:8080/graph.json
search for 10feede6b0c2
http://map.gl.wupper.ffrl.de/
go to the graph and click some nodes in a mesh
sometimes you will click a node in a mesh and will be 'redirected' to a duplicate at the other end, which doesn't have any links
The text was updated successfully, but these errors were encountered: