Support custom CA for 1-way TLS #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than silently failing
This lets you use kt with unauthenticated clusters exposed via a k8s ingress, e.g. as deployed by strimzi
|
👋 @jvansanten thank you for contributing! the changes lgtm -- thanks for boyscouting as well 🙏 do you want to follow up with a readme update? |
fgeller
reviewed
Sep 9, 2023
| @@ -271,6 +292,12 @@ func setupAuthTLS(auth authConfig, saramaCfg *sarama.Config) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func qualifyPath(argFN string, target *string) { | |||
| if *target != "" && !filepath.IsAbs(*target) { | |||
There was a problem hiding this comment.
i think we need to also check if filepath.Dir(*target) == "." -- cf test failures for test-secrets/cert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Kafka clusters use TLS as a backdoor load-balancing mechanism, see e.g. strimzi's ingress feature. These are impossible to use with kt if the cluster uses a self-signed certificate, as it uses a default tls.Config in 1-way TLS mode. This PR adds the following features:
groupandtopiccommands, rather than silently falling back to an unencrypted connection