Skip to content

Allow overriding of the token through a arg #723

Allow overriding of the token through a arg

Allow overriding of the token through a arg #723

Triggered via pull request December 11, 2023 09:17
@hatchanhatchan
synchronize #261
tokenifying
Status Success
Total duration 2m 19s
Artifacts 2

build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 warnings
redundant guard: src/update.rs#L130
warning: redundant guard --> src/update.rs:130:42 | 130 | Some((sha256_hash, file)) if file == "fp" => Some(sha256_hash.to_owned()), | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards = note: `#[warn(clippy::redundant_guards)]` on by default help: try | 130 - Some((sha256_hash, file)) if file == "fp" => Some(sha256_hash.to_owned()), 130 + Some((sha256_hash, "fp")) => Some(sha256_hash.to_owned()), |
this expression creates a reference which is immediately dereferenced by the compiler: src/templates.rs#L543
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/templates.rs:543:36 | 543 | let notebook = notebook_create(&client, workspace_id, notebook) | ^^^^^^^ help: change this to: `client` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of `unwrap_or_else` to construct default value: src/notebooks.rs#L194
warning: use of `unwrap_or_else` to construct default value --> src/notebooks.rs:194:45 | 194 | .front_matter(args.front_matter.unwrap_or_else(FrontMatter::new)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Artifacts

Produced during runtime
Name Size
fp Expired
37.2 MB
manifest.json Expired
482 Bytes