Version 0.2: simplification and clarification #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpaljak
requested review from
miguelcardo and
sergkh
and removed request for
miguelcardo
sergkh
approved these changes
Dec 12, 2018
|  | ||
|
|
||
|
|
||
| ``` |
There was a problem hiding this comment.
I would move that to a separate file
There was a problem hiding this comment.
Until finalization, it is easier to keep it as such "editable link". For finalization, the images folder shall be cleaned.
miguelcardo
reviewed
Dec 14, 2018
|
|
||
| The sequence of APDUs is then divided into packets that fit into the maximum length for this characteristic, following the structure [below](#packet). | ||
| #### Characteristic: APDU Response | ||
| Used by the Client to retrieve the Response APDU fragments corresponding to the processing of a previous Command APDU. The Client will read this characteristic only after receiving *APDU Response Ready* notification. Response APDU fragments will be encoded in the same structure as command APDUs in the figure below. | ||
|
|
||
| #### Characteristic: Conversation Finished |
There was a problem hiding this comment.
Shouldn't this be called "Close Communication"? Conversation Finished was removed from the table
|  | ||
|
|
||
|
|
||
| ``` |
|
|
||
| ### Responses | ||
| When sending a Command APDU, the Client sends the different fragments in order, waiting for the ACK from the Server (sent by lower layers of the BLE stack). |
There was a problem hiding this comment.
The "Server" is not identified in the diagram. Wouldn't it better to use the same actor names as in the sequence?
|
stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #14: Only a single APDU at a time can be exchanged over BLE (as a SE can only process a single command at a time) and the responsibility of GET RESPONSE handling is clarified
Address #7: one level of wrapping and related packet overhead is removed by addressing #14
Address #13: recommend re-sending the notification if response is not read in a timely fashion
Address #11: have the response notify include an error code
Further reduction of the overhead in payload headers should be considered.