-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add sound when awaiting ledger interaction #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes SGTM, with two comments to consider:
- Personally, I configured my terminal to turn ANSI beep sequence into a screen flash, so this is probably not going to work for me. (I didn't check, TBH.)
- In the past, I had a good experience using
say
, a built-in macOS CLI utility. That may not be portable to Linux/Windows, though.
Beeper uses this: process.stdout.write('\u0007'); Can you try if that creates a sound for you? For me it plays a sound and makes the screen flash.
I'm also using that in my shall, eg |
node -e "process.stdout.write('\u0007');" For me, this flashes the screen, but there is no sound.
IDK, TBH. I don't want us to spend too much time on this, it does not seem to worth the effort. What is the simplest solution? How about we execute the |
We can also land this PR as-is and improve it iteratively later. |
Up to you! I'm fine with the solution as is because it does everything I need. I propose you follow up with a |
I would say it's fair to assume that a shell ascii beep works, and I think your setup diverges from the norm, therefore I think following up with |
SGTM 👌🏻 |
Since it's a long running script, notify the operator that a ledger interaction is necessary