Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #637: added test for fs.fsync() #638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yatsenko-julia
Copy link
Contributor

No description provided.

@yatsenko-julia yatsenko-julia changed the title Issue 637 fix #637: added test for fs.fsync() Dec 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          16       16           
  Lines        1742     1742           
=======================================
  Hits         1509     1509           
  Misses        233      233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6975861...cef05cf. Read the comment docs.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in fs.fsync.spec.js look good, but can you rebase to get rid of your extra changes in fs.ftruncate.spec.js, which I are from your other PR? I've merged that, so it should pick it up from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants