Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue698 #705

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue698 #705

wants to merge 2 commits into from

Conversation

pbrahmbhatt3
Copy link
Contributor

@pbrahmbhatt3 pbrahmbhatt3 commented Jan 29, 2019

issue123: I have changed all the constants that were declared using var to const.

@codecov-io
Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232
Impacted Files Coverage Δ
src/filesystem/implementation.js 83.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...491104b. Read the comment docs.

@abdiG
Copy link

abdiG commented Jan 31, 2019

Awesome work. You seem to have left some variable as var. i recommend to use let

@otkach
Copy link
Contributor

otkach commented Jan 31, 2019

Good job, but i'll suggest to add 'use strict'; to your files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants