Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open out-of-scope URLs in default browser" doesn't close temporary tab when PWA is full screen on macOS #547

Open
jmadren opened this issue Sep 1, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jmadren
Copy link

jmadren commented Sep 1, 2024

Description

As stated elsewhere, when the "Open out-of-scope URLs in default browser" option is enabled, it causes a tab in the PWA to also open, which is subsequently closed. The problem is, at least on macOS (haven't tried Windows), if the PWA is in full screen mode, the tab that's opened in the PWA does not get closed automatically.

Steps to Reproduce

  1. Make PSA full-screen (green button)
  2. Click on a link that should open in the default browser
  3. A blank tab is now still open in the PWA

Additional Information

Note that when in full-screen mode, the new tab in the PWA is actually a new window. I'm guessing that has something to do with this issue. But, if I choose New Default Browser from the menu in the PWA, it opens a new tab in my current browser with no tab or window opened in the PWA. Of course, New Window opens a new window for the PWA.

Affected Websites

  • mail.google.com

Environment

  • Operating system: macOS 12.7.6
  • System architecture: x86
  • PWAsForFirefox extension version: 2.12.1
  • Firefox version: 129.0.2
@jmadren jmadren added the bug Something isn't working label Sep 1, 2024
@filips123 filips123 moved this to To Do in PWAsForFirefox Sep 16, 2024
@filips123 filips123 added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: To Do
Development

No branches or pull requests

2 participants