Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscaler and TeaCache #113

Open
azrahello opened this issue Jan 12, 2025 · 2 comments
Open

Upscaler and TeaCache #113

azrahello opened this issue Jan 12, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@azrahello
Copy link
Contributor

azrahello commented Jan 12, 2025

Hi, would it be possible to implement an upscaler? Either using ControlNet like this: https://huggingface.co/jasperai/Flux.1-dev-Controlnet-Upscaler or something similar to https://github.com/ssitu/ComfyUI_UltimateSDUpscale? I find the ability to upscale images very useful. I was wondering if there’s a chance to implement it.
P.S. If you need a tester for your projects, I’m always available! 😉
Edit.

Yesterday, I tested this paper and this repository in ComfyUI using FLUX1 dev in 8-bit GGUF. By following this process, I was able to almost halve the number of iterations and the time required, effectively making it faster than MLX. I was wondering if this could be useful and if it could be implemented. It would be amazing to generate images with FLUX in almost half the traditional time!

@azrahello azrahello changed the title Upscaler Upscaler and TeaCache Jan 13, 2025
@filipstrand
Copy link
Owner

Hi @azrahello! Upscaling is interesting for sure and should be something we should support! Thanks for linking the ControlNet one, I will look into this to get a sense of how much work it would take to implement... Depending on a few personal factors, I might be able to spend more time than typical on MFLUX over the coming time so I am really happy with your feature suggestions here :)

TeaCache looks awesome, definitely worth investigating! On their site, they have an example to get a sense of the quality degradation, and that looks really promising.
Screenshot 2025-01-14 at 19 27 49

Would you say with your own testing that you got similary good results, or do they vary a lot? Anyway, really cool!

@filipstrand filipstrand added the enhancement New feature or request label Jan 14, 2025
@azrahello
Copy link
Contributor Author

this is the output of comfy without teacache,
Requested to load Flux
100%|███████████████████████████████████████████| 25/25 [01:17<00:00, 3.09s/it]
Prompt executed in 77.91 seconds
got prompt
this with teacache
Requested to load Flux
100%|███████████████████████████████████████████| 25/25 [00:40<00:00, 1.62s/it]
Prompt executed in 40.91 seconds this with teacache
ComfyUI_00135_
this without teacache.
ComfyUI_00134_
with a value of 0.40.
This is made with mflux.
image
time mflux-generate
--prompt "Luxury food photograph"
--model dev
--steps 25
--seed 1010
--height 512
--width 768
Fetching 8 files: 100%|████████████████████████| 8/8 [00:00<00:00, 75573.05it/s]
Fetching 7 files: 100%|████████████████████████| 7/7 [00:00<00:00, 19277.83it/s]
100%|███████████████████████████████████████████| 25/25 [01:02<00:00, 2.51s/it]
mflux-generate --prompt "Luxury food photograph" --model dev --steps 25 --see 3,65s user 39,06s system 64% cpu 1:06,27 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants