CTOOLS-348: allow timeout and rate limit retry configuration #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cg-finbourne
force-pushed
the
feature/CTOOLS-348
branch
6 times, most recently
from
9c00f2b to
7c5dda4
Compare
cg-finbourne
force-pushed
the
feature/CTOOLS-348
branch
from
7c5dda4 to
84f14e7
Compare
| api.api_client.close() | ||
|
|
||
| if async_req: | ||
| result = result.get(timeout=60) |
There was a problem hiding this comment.
What is the timeout for? Is this simulating the async request?
There was a problem hiding this comment.
the timeout is just so that the test won't hang forever. If the task hasn't finished by the timeout then an exception will be raised. I've put it to a bigger timeout that it needs to allow for debugging through the test
There was a problem hiding this comment.
for context when async_req is set to True, the method call is run on a background queue to simulate async behaviour
. This happens in both the sync and the async api_client
There was a problem hiding this comment.
Cool thanks, that makes sense
Matt-Storey-Finbourne
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
developbranchDescription of the PR
Describe the code changes for the reviewers, explain the solution you have provided and how it fixes the issue