Feature/can 16 add fix for missing template #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
develop
branchBackground
How were the changes implemented
generate-local
andgenerate-cicd
to check if a description template exists, if it does, normal service is resumed. If it does not then./generate/templates/description.mustache
created with the following content:How Has This Been Tested?
APPLICATION_NAME
environment variable tomy_new_lib
and rangenerate-cicd
andgenerate-local
before and after making this change. Errors before, no error after.How this can be tested
APPLICATION_NAME
environment variable tomy_new_lib
(export APPLICATION_NAME=my_new_lib
) - this will ensure that there is nogenerate/templates/description.my_new_lib.mustache
found to test the new logic.just generate-local
and observe the warning message in the logs:generate/.output/README.md
file should contain a description that reads "[INTERNAL] FINBOURNE Technology my_new_lib SDK" at the topecho "My new Lib - FINBOURNE TECHNOLOGY" > generate/templates/description.my_new_lib.mustache
just generate-local
and observe no warning message in the logs.generate/.output/README.md
file contains the text "My new Lib - FINBOURNE TECHNOLOGY"