Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Py] Fail to run ./py/bin/scripts/format_toml_files.sh in pre-commit hooks #1935

Open
kirgrim opened this issue Feb 11, 2025 · 0 comments
Open
Assignees
Milestone

Comments

@kirgrim
Copy link
Contributor

kirgrim commented Feb 11, 2025

When trying to execute ./py/bin/scripts/format_toml_files.sh with rust-parallel -j4 taplo format it gives the following error:

2025-02-11T15:27:48.554530Z ERROR rust_parallel::command: spawn error command: cmd="./.cargo/bin/taplo",args=["format", "--config", "./projects/genkit/py/taplo.toml", "./projects/genkit/py/taplo.toml\0~/projects/genkit/py/plugins/chroma/pyproject.toml\0~/projects/genkit/py/plugins/pinecone/pyproject.toml\0~/projects/genkit/py/plugins/firebase/pyproject.toml\0~/projects/genkit/py/plugins/google-ai/pyproject.toml\0~/projects/genkit/py/plugins/vertex-ai/pyproject.toml\0~/projects/genkit/py/plugins/google-cloud/pyproject.toml\0~/projects/genkit/py/plugins/ollama/pyproject.toml\0~/projects/genkit/py/pyproject.toml\0~/projects/genkit/py/tests/smoke/pyproject.toml\0~/projects/genkit/py/samples/hello/pyproject.toml\0~/projects/genkit/py/.venv/lib/python3.12/site-packages/dateutil-stubs/METADATA.toml\0~/projects/genkit/py/.venv/lib/python3.12/site-packages/jupyterlab/tests/mock_packages/test_no_hyphens/pyproject.toml\0~/projects/genkit/py/.venv/lib/python3.12/site-packages/jupyterlab/tests/mock_packages/test-hyphens-underscore/pyproject.toml\0~/projects/genkit/py/.venv/lib/python3.12/site-packages/jupyterlab/tests/mock_packages/test-hyphens/pyproject.toml\0~/projects/genkit/py/packages/dotprompt/pyproject.toml\0~/projects/genkit/py/packages/genkit/pyproject.toml\0~/projects/genkit/py/packages/handlebarz/pyproject.toml\0"],line=stdin:1: nul byte found in provided data

On the other hand, simplifying the script to:

taplo format --config "${GIT_ROOT}/py/taplo.toml" executes successfully

@kirgrim kirgrim changed the title [Py] Fail to run [Py] Fail to run ./py/bin/scripts/format_toml_files.sh in pre-commit hooks Feb 11, 2025
@kirgrim kirgrim changed the title [Py] Fail to run ./py/bin/scripts/format_toml_files.sh in pre-commit hooks [Py] Fail to run Feb 11, 2025
@kirgrim kirgrim changed the title [Py] Fail to run [Py] Fail to run ./py/bin/scripts/format_toml_files.sh in pre-commit hooks Feb 11, 2025
@yesudeep yesudeep added this to the py-0.1.0 milestone Feb 11, 2025
yesudeep added a commit that referenced this issue Feb 12, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
yesudeep added a commit that referenced this issue Feb 12, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
yesudeep added a commit that referenced this issue Feb 13, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
yesudeep added a commit that referenced this issue Feb 13, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
yesudeep added a commit that referenced this issue Feb 13, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Fixes snake_case for several Python variables.
- [ ] Configures the schemas.py code generator to generate snake_case
  field names to avoid lint reports and wraps the actual name in Field()
  metadata.
- [ ] Clean up some lint.
- [ ] Removes go-vulncheck from the pre-commit hook while retaining it
  during pre-push (easy to skip this using `-f --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Retains go-vulncheck during pre-push (easy to skip this using `-f
  --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Retains go-vulncheck during pre-push (easy to skip this using `-f
  --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Retains go-vulncheck during pre-push (easy to skip this using `-f
  --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Retains go-vulncheck during pre-push (easy to skip this using `-f
  --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Retains go-vulncheck during pre-push (easy to skip this using `-f
  --no-verify`).
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
- [ ] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
- [ ] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Reverts snake_casing of some fields that broke genkit start.
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  messafe format.
- [ ] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…breakage #1935

ISSUE: #1935

CHANGELOG:
- [ ] Reverts snake_casing of some fields that broke genkit start.
- [ ] Addresses error handling and parallelized formatting for toml
  files.
- [ ] Configures the ruff formatter to use requested format.
- [ ] Clean up some lint.
- [ ] Update copyright headers in files missing them.
- [ ] Add scripts to add and check license headers.
- [ ] Add checks to ensure we have a conventional commit message format.
- [ ] Add a commit message template that uses the conventional commit
  message format.
- [ ] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…mat check

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…mat check

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…age #1935

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…age #1935

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…age #1935

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…age #1935

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
yesudeep added a commit that referenced this issue Feb 14, 2025
…age #1935 (#1978)

ISSUE: #1935

CHANGELOG:
- [x] Addresses error handling and parallelized formatting for toml files.
- [x] Configures the ruff formatter to use requested format.
- [x] Clean up some lint.
- [x] Update copyright headers in files missing them.
- [x] Add scripts to add and check license headers.
- [x] Add checks to ensure we have a conventional commit message format.
- [x] Add a commit message template that uses the conventional commit message format.
- [x] Add biomejs configuration for later use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants