Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] getTransactionsWithPageInfo does not throw with incorrect credentials and empty filter #164

Open
eva-ortuno opened this issue Apr 27, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@eva-ortuno
Copy link

eva-ortuno commented Apr 27, 2023

Describe the bug
When calling getTransactionsWithPageInfo() without any of the optionnal parameters and incorrect credentials (for example privateKey set to "-----BEGIN PRIVATE KEY-----"), no error is thrown and the response is an empty list.

To Reproduce
Steps to reproduce the behavior:

  1. const fireblocks = new FireblocksSDK("-----BEGIN PRIVATE KEY-----", "test");
  2. const tx = fireblocks.getTransactionsWithPageInfo()
  3. result is { transactions: [], pageDetails: { prevPage: '', nextPage: '' } }

Reproduced on Sandbox account credentials so url set to https://sandbox-api.fireblocks.io

Expected behavior
the usual error message would be secretOrPrivateKey must be an asymmetric key when using RS256 expected
Ideally if the credentials are incorrect, an error would be thrown directly at step 1 when creation to fireblocks instance.

Version:

  • fireblocks-sdk version:4.1.0
  • npm version: 8.3.1
  • node version: 16.14.0
@eva-ortuno eva-ortuno added the bug Something isn't working label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants