Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing type(s) from TransactionStatus enum #274

Open
HarshitJoshi opened this issue Apr 26, 2024 · 0 comments
Open

[Bug] Missing type(s) from TransactionStatus enum #274

HarshitJoshi opened this issue Apr 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@HarshitJoshi
Copy link

Describe the bug
Some statuses related to transaction creation response seem to be missing from the TransactionStatus enum, for instance, "PENDING_ENRICHMENT"

To Reproduce
Steps to reproduce the behavior:

  1. Create an ETH transaction (createTransaction)
  2. Review the response to the transaction creation request :
{
   "type":"TRANSACTION_STATUS_UPDATED",
   "tenantId":"***redacted***",
   "timestamp":1713976676073,
   "data":{
      "id":"a6c238b4-b203-4ab8-919d-afa40d244f1f",
      "createdAt":1713976661089,
      "lastUpdated":1713976661557,
      "assetId":"ETH",
      "source":{
         "id":"3",
         "type":"VAULT_ACCOUNT",
         "name":"Withdrawal 1",
         "subType":""
      },
      "destination":{
         "id":"6564f824-4c35-69f7-b392-4f956c0dade4",
         "type":"INTERNAL_WALLET",
         "name":"***redacted***",
         "subType":"Internal"
      },
      "amount":30,
      "sourceAddress":"",
      "destinationAddress":"",
      "destinationAddressDescription":"",
      "destinationTag":"",
      "status":"PENDING_ENRICHMENT",
      "txHash":"",
      "subStatus":"",
      "signedBy":[
         
      ],
      "createdBy":"52849aef-cd83-4de0-bb64-6963a3e30ac5",
      "rejectedBy":"",
      "amountUSD":94973.41,
      "addressType":"WHITELISTED",
      "note":"Rebalance",
      "exchangeTxId":"",
      "requestedAmount":30,
      "feeCurrency":"ETH",
      "operation":"TRANSFER",
      "customerRefId":null,
      "amountInfo":{
         "amount":"30",
         "requestedAmount":"30",
         "amountUSD":"94973.41"
      },
      "feeInfo":{
         
      },
      "destinations":[
         
      ],
      "externalTxId":null,
      "blockInfo":{
         
      },
      "signedMessages":[
         
      ],
      "assetType":"BASE_ASSET"
   }
}
  1. The fireblocks-sdk-js is missing the mapping for the status above (PENDING_ENRICHMENT).

Expected behavior
TransactionStatus to contain all expected mappings related to Transaction statuses.

Version:

  • fireblocks-sdk version: v5.25.1
@HarshitJoshi HarshitJoshi added the bug Something isn't working label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants