Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading profiles from a file in a non-Firefox browser is delayed by five seconds #3638

Open
mstange opened this issue Nov 5, 2021 · 0 comments
Open

Loading profiles from a file in a non-Firefox browser is delayed by five seconds #3638

mstange opened this issue Nov 5, 2021 · 0 comments
Assignees
@mstange

Comments

@mstange
Copy link
Contributor

mstange commented Nov 5, 2021 •
edited by data-sync-user
Loading

Loading a simple profile from a file in Chrome or Safari waits for five seconds for a reply to the WebChannel status message. We added the wait for the WebChannel on the file loading path in #3501, in order to allow symbolicating profiles from files with the help of the browser.

We can skip the WebChannel connection attempt if the userAgent does not contain Firefox.

┆Issue is synchronized with this Jira Task
@mstange mstange self-assigned this Nov 5, 2021
@mstange mstange mentioned this issue Nov 8, 2021
Merged
mstange added a commit to mstange/perf.html that referenced this issue Nov 15, 2021
@mstange
Make <Root> establish the browser connection.
296ef5d 
This moves the call to createBrowserConnection all the way to the outside.
It also removes the user agent override: We will now only wait for the
WebChannel if we're running in a browser with a Firefox userAgent.
Fixes firefox-devtools#3638.

I've kept the tests mostly as-is. I'm planning to simplify them in
future commits.
@mstange mstange mentioned this issue Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstange mstange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mstange