Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading this profile is too slow #4668

Open
mstange opened this issue Jun 16, 2023 · 2 comments
Open

Loading this profile is too slow #4668

mstange opened this issue Jun 16, 2023 · 2 comments
Assignees
@mstange
Labels
perf Issues where the profiler itself is slow.

Comments

@mstange
Copy link
Contributor

mstange commented Jun 16, 2023 •
edited by data-sync-user
Loading

Loading this profile currently takes seven seconds on my machine: https://share.firefox.dev/3CxXqdh

Profile: https://share.firefox.dev/3qP8iB3

┆Issue is synchronized with this Jira Task
@mstange mstange added the perf Issues where the profiler itself is slow. label Jun 16, 2023
@mstange mstange self-assigned this Jun 16, 2023
mstange added a commit to mstange/perf.html that referenced this issue Jun 16, 2023
@mstange
Speed up dropFunction by using a typed array instead of a sparse JS a…
197e034 
…rray.

This improves firefox-devtools#4668 from 7.0 seconds to 1.6 seconds.

Before: https://share.firefox.dev/3qP8iB3
After: https://share.firefox.dev/43JVAC8
mstange added a commit to mstange/perf.html that referenced this issue Jun 16, 2023
@mstange
Speed up filterSamples by taking advantage of sortedness.
c3c4ecb 
On the profile from firefox-devtools#4668 this makes filterSamples 10x faster. It changes
the algorithm complexity from N * M to N + M, N being the number of
samples and M the number of ranges.

Before: https://share.firefox.dev/3Ji8qPD
After: https://share.firefox.dev/3CAtmxA
This was referenced Jun 16, 2023
Merged
Merged
mstange added a commit to mstange/perf.html that referenced this issue Jun 19, 2023
@mstange
Speed up dropFunction by using a typed array instead of a sparse JS a…
f7ed6f4 
…rray.

This improves firefox-devtools#4668 from 7.0 seconds to 1.6 seconds.

Before: https://share.firefox.dev/3qP8iB3
After: https://share.firefox.dev/43JVAC8
mstange added a commit to mstange/perf.html that referenced this issue Jun 19, 2023
@mstange
Speed up filterSamples by taking advantage of sortedness.
1319b66 
On the profile from firefox-devtools#4668 this makes filterSamples 10x faster. It changes
the algorithm complexity from N * M to N + M, N being the number of
samples and M the number of ranges.

Before: https://share.firefox.dev/3Ji8qPD
After: https://share.firefox.dev/3CAtmxA
mstange added a commit to mstange/perf.html that referenced this issue Jun 19, 2023
@mstange
Speed up filterSamples by taking advantage of sortedness.
10d8606 
On the profile from firefox-devtools#4668 this makes filterSamples 10x faster. It changes
the algorithm complexity from N * M to N + M, N being the number of
samples and M the number of ranges.

Before: https://share.firefox.dev/3Ji8qPD
After: https://share.firefox.dev/3CAtmxA
mstange added a commit to mstange/perf.html that referenced this issue Jun 20, 2023
@mstange
Speed up filterSamples by taking advantage of sortedness.
d685977 
On the profile from firefox-devtools#4668 this makes filterSamples 10x faster. It changes
the algorithm complexity from N * M to N + M, N being the number of
samples and M the number of ranges.

Before: https://share.firefox.dev/3Ji8qPD
After: https://share.firefox.dev/3CAtmxA
@julienw
Copy link
Contributor

julienw commented Aug 10, 2023

Hey @mstange thanks to your recent performance fixes (thanks!), this looks better now. Do you think we could close this issue?

@mstange
Copy link
Contributor Author

mstange commented Oct 3, 2023

There's one more fix I'd like to make before calling this fixed: Collapsing multiple drop function transforms into a single drop functions transform. Then this will be quite fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstange mstange

Labels
perf Issues where the profiler itself is slow.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienw @mstange