Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually del instead of put via null #34

Closed
erhant opened this issue May 18, 2023 · 3 comments
Closed

Actually del instead of put via null #34

erhant opened this issue May 18, 2023 · 3 comments
Assignees
@erhant
Labels
enhancement New feature or request

Comments

@erhant
Copy link
Member

erhant commented May 18, 2023

We are not using del yet, as it may not completely remove every key in the cache there is delete function defined in SortKeyCache but it is not exported in KV yet.
@erhant erhant added the enhancement New feature or request label May 18, 2023
@erhant
Copy link
Member Author

erhant commented May 18, 2023

https://github.com/firstbatchxyz/hollowdb/blob/master/contracts/hollowDB/actions/crud/remove.ts#L35

@erhant erhant self-assigned this May 18, 2023
@erhant
Copy link
Member Author

erhant commented May 30, 2023

Waiting for del to be fixed in Redis cache implementation

@erhant
Copy link
Member Author

erhant commented Jun 1, 2023

#36 fixes this

@erhant erhant closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erhant erhant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erhant