Feat/lib 1271 fzlayout #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crish15
reviewed
Nov 6, 2024
| }) | ||
|
|
||
| expect(wrapper.html()).toMatchSnapshot() | ||
| }) |
There was a problem hiding this comment.
I would add other tests based on the values the layout can take
oxcened
reviewed
Nov 11, 2024
packages/layout/src/FzLayout.vue
Outdated
Comment on lines
3
to
32
| <template v-if="['twoColumns', 'leftShoulder', 'rightShoulderNavbar', 'squares'].includes(props.layout)"> | ||
| <slot></slot> | ||
| </template> | ||
| <template v-if="props.layout === 'leftShoulderNavbar'"> | ||
| <div class="col-span-2"> | ||
| <slot name="navbar"></slot> | ||
| </div> | ||
| <div class="col-span-2"> | ||
| <slot name="header"></slot> | ||
| </div> | ||
| <div class="col-span-2 lg:col-span-1"> | ||
| <slot name="left-shoulder"></slot> | ||
| </div> | ||
| <div class="col-span-2 lg:col-span-1"> | ||
| <slot></slot> | ||
| </div> | ||
| </template> | ||
| <template v-if="props.layout === 'rightShoulderNavbar'"> | ||
| <div class="col-span-2"> | ||
| <slot name="navbar"></slot> | ||
| </div> | ||
| <div class="col-span-2"> | ||
| <slot name="header"></slot> | ||
| </div> | ||
| <div class="col-span-2 lg:col-span-1"> | ||
| <slot></slot> | ||
| </div> | ||
| <div class="col-span-2 lg:col-span-1"> | ||
| <slot name="right-shoulder"></slot> | ||
| </div> |
There was a problem hiding this comment.
I would rather have a single template for each layout, it's more redundant but makes it more clear and easier to maintain
There's also two default slots for rightShoulderNavbar
There was a problem hiding this comment.
I'll fix the double slot. As per the single template, I actually prefer this way at least for "default slot - only" templates.
packages/layout/src/FzLayout.vue
Outdated
Comment on lines
49
to
67
| res = 'grid-rows-auto' | ||
| break; | ||
| case 'twoColumns': | ||
| res = 'grid-cols-1 grid-rows-[60px_1fr] lg:grid-rows-1 lg:grid-cols-2' | ||
| break; | ||
| case 'leftShoulder': | ||
| res = 'grid-rows-[60px_1fr] grid-cols-1 lg:grid-rows-1 lg:grid-cols-[260px_1fr]' | ||
| break; | ||
| case 'leftShoulderNavbar': | ||
| res = 'grid-rows-[40px_160px_60px_1fr] grid-cols-1 lg:grid-rows-[40px_160px_1fr] lg:grid-cols-[260px_1fr]' | ||
| break; | ||
| case 'rightShoulderNavbar': | ||
| res = 'grid-rows-[40px_160px_60px_1fr] grid-cols-1 lg:grid-rows-[40px_160px_1fr] lg:grid-cols-[1fr_260px]' | ||
| break; | ||
| case 'squares': | ||
| res = 'grid-cols-1 grid-rows-auto sm:grid-cols-2 sm:grid-rows-auto md:grid-cols-3 md:grid-rows-auto auto-rows-[332px]' | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
I'd just return those strings. no need for res
There was a problem hiding this comment.
I very much prefer functions to have a single exit if possible, except for quick "out" conditions at the very top when needed.
oxcened
approved these changes
Dec 10, 2024
Crish15
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: LIB-1271