Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update DNSLink when content is available on gateway #362

Closed
icidasset opened this issue Jul 30, 2020 · 2 comments
Closed

Only update DNSLink when content is available on gateway #362

icidasset opened this issue Jul 30, 2020 · 2 comments
Assignees
Labels
⚡ dns Route53 or other DNS ☁️ server Web API

Comments

@icidasset
Copy link
Contributor

Problem

Otherwise data may get lost.
See oddsdk/ts-odd#77 for more context.

Solution

Wait for content to be available and then update DNSLink.
Also report progress to API consumer.

Related to #312

@icidasset icidasset added the 🐛 bug Something isn't working label Jul 30, 2020
@expede expede added ☁️ server Web API ⚡ dns Route53 or other DNS and removed 🐛 bug Something isn't working labels Aug 2, 2020
@expede
Copy link
Member

expede commented Aug 2, 2020

Not a bug per se — more a question of tradeoffs, since an online peer with those changes can serve them instantly.

The idea is that by making this change the server will behave more like a traditional uploader, and only provide the ID to others when it has a copy of the data. We can additionally broadcast the new Merkle root over IPNS pubsub (#363). This gives us the best of both: new pulls get the last known-good state. Active/online users get alerted that something has changed.

@expede expede self-assigned this Aug 11, 2020
@icidasset
Copy link
Contributor Author

We already have this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ dns Route53 or other DNS ☁️ server Web API
Projects
None yet
Development

No branches or pull requests

2 participants