Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for new association type composite keys #131

Closed
2 of 4 tasks
reubster opened this issue Nov 1, 2024 · 4 comments · Fixed by #132
Closed
2 of 4 tasks

[Feature] Support for new association type composite keys #131

reubster opened this issue Nov 1, 2024 · 4 comments · Fixed by #132
Assignees
Labels
status:in_progress Currently being worked on type:enhancement New functionality or enhancement

Comments

@reubster
Copy link

reubster commented Nov 1, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Following the breaking changes to the Hubspot API's and ingestion, the related objects in hubspot source need updating to;

  • add the Category column
  • update data uniqueness tests to check to include category in the test columns

How would you implement this feature?

Since the change was introduced, we now have duplicate type id's in ASSOCIATION_TYPE

ID NAME CATEGORY LABEL FROM_OBJECT_TYPE TO_OBJECT_TYPE _FIVETRAN_DELETED _FIVETRAN_SYNCED
3 day_to_day_contact USER_DEFINED Day to Day Contact deal contact false 2024-11-01 12:11:20.616000000 +00:00
1 onboarding_contact USER_DEFINED Onboarding Contact deal contact false 2024-11-01 12:11:20.616000000 +00:00
1 contact_to_company HUBSPOT_DEFINED Primary contact company false 2024-11-01 12:11:20.989000000 +00:00
3 day_to_day_contact HUBSPOT_DEFINED deal contact false 2024-11-01 12:11:20.616000000 +00:00

Describe alternatives you've considered

We've currently disabled unit tests for hubspot_source and hubspot, but this is just temporary to ensure our pipelines complete.

Remove custom relationships in Hubspot - not acceptable to users

Fork dbt_hubspot_source and update - would very much prefer to keep using it

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance.
  • No.

Anything else?

No response

@reubster reubster added the type:enhancement New functionality or enhancement label Nov 1, 2024
@fivetran-reneeli
Copy link
Contributor

Hi @reubster thanks for raising this! We have been made aware of this connector update and are actively working on changes to this package currently.

I saw you checked that you were interested in contributing! I will have a PR and branch opened in the coming days; it would be super helpful if you were open to testing that branch!

@fivetran-reneeli fivetran-reneeli self-assigned this Nov 1, 2024
@fivetran-reneeli fivetran-reneeli added the status:in_progress Currently being worked on label Nov 1, 2024
@fivetran-reneeli
Copy link
Contributor

fivetran-reneeli commented Nov 4, 2024

Hi @reubster! Here is the branch I created that hopefully addresses this test failure. Let me know once you get a chance to run it:

branch: bugfix/category_add

Here is what you would temporarily place in your packages.yml:

## if you are only using the dbt_hubspot_source package:
  - git: https://github.com/fivetran/dbt_hubspot_source.git
    revision: bugfix/category_add
    warn-unpinned: false

## if you are using the dbt_hubspot package
  - git: https://github.com/fivetran/dbt_hubspot.git
    revision: bugfix/category_add
    warn-unpinned: false

@reubster
Copy link
Author

reubster commented Nov 5, 2024

hi @fivetran-reneeli

Tested and this works a treat. Thanks!!

@fivetran-reneeli
Copy link
Contributor

Thanks @reubster for working with us! This has been merged into the main branch.

@fivetran-reneeli fivetran-reneeli linked a pull request Nov 12, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in_progress Currently being worked on type:enhancement New functionality or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants