Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update determination of discount line item in recharge__charge_line_item_history #18

Open
2 of 4 tasks
fivetran-catfritz opened this issue Jun 28, 2024 · 0 comments
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Jun 28, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Currently, in recharge__charge_line_item_history, the discount line items are calculated. The intent was to provide a separate line item for each discount that may have been used, however this is proving to over-calculate discounts per an investigation with @fivetran-joemarkiewicz today. This is because discounts are reported as percentages from the DISCOUNT table rather than dollar amounts.

This should be revised to provide only one line item for discounts using the total_discounts from charge as the discount amount, so we get the actual amount and not rely on a calculation.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz added the type:enhancement New functionality or enhancement label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant