-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening partition that is marked as deleted #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the test case to check for the specific enum variant.
Good idea to move the marker check into the Partition
itself. 👍
Thank you for you time @marvin-j97 . I would like to contribute more to this and other projects of yours. Please let me know how I can get involved. |
I'm currently pretty deep into finishing V2, so a lot of stuff is currently blocked or in progress. There are two minor examples that are pretty low-hanging fruits - #48 and #49 - which I'm not really getting around to implementing right now. |
Which issue does this PR close?
Closes #59
Are these changes tested?
Tested changes maually as suggested in #59