Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening partition that is marked as deleted #60

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

dharanad
Copy link
Contributor

@dharanad dharanad commented Jun 30, 2024

Which issue does this PR close?

Closes #59

Are these changes tested?

Tested changes maually as suggested in #59

@dharanad dharanad marked this pull request as ready for review June 30, 2024 20:18
src/keyspace.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@marvin-j97 marvin-j97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the test case to check for the specific enum variant.

Good idea to move the marker check into the Partition itself. 👍

@dharanad
Copy link
Contributor Author

dharanad commented Jul 1, 2024

Thank you for you time @marvin-j97 . I would like to contribute more to this and other projects of yours. Please let me know how I can get involved.

@marvin-j97
Copy link
Collaborator

Thank you for you time @marvin-j97 . I would like to contribute more to this and other projects of yours. Please let me know how I can get involved.

I'm currently pretty deep into finishing V2, so a lot of stuff is currently blocked or in progress.

There are two minor examples that are pretty low-hanging fruits - #48 and #49 - which I'm not really getting around to implementing right now.

@marvin-j97 marvin-j97 changed the title Opening partition throws error if deleted marker exists Fix opening partition that is marked as deleted Jul 8, 2024
@marvin-j97 marvin-j97 added the fix label Jul 8, 2024
@marvin-j97 marvin-j97 merged commit 9d9f5ed into fjall-rs:main Jul 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recreating a deleted partition may be undefined behaviour
2 participants