Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FACT comments 2.0 #1302

Open
dorpvom opened this issue Nov 19, 2024 · 0 comments
Open

FACT comments 2.0 #1302

dorpvom opened this issue Nov 19, 2024 · 0 comments

Comments

@dorpvom
Copy link
Collaborator

dorpvom commented Nov 19, 2024

Feature description

The comment feature in FACT needs to be thoroughly upgraded to offer a real value in collaboration and note keeping. Some issues that should be addressed are:

  • Aggregate comments on firmware level somehow
    • Making sure no comments are lost
  • Highlight on top of analysis page (tag?) if comments exist
  • Attach related plugin to comment
    • If navigated to comment, open plugin result (akin to pattern search, summary)
  • Add comment should be modal
  • Comments need not be collapsed
  • Comment meta (user, timestamp) can be hidden and shown if wanted (hover, collapsible, ..)

Proposed plan of action:

  1. Identify additional features, code dependecies
  2. Adapt database scheme to fit analysis plugin
  3. First PR: Add analysis plugin relation to comments
  4. Second PR: Comment highlighting and aggregation
  5. Third PR: Modal, new look comment rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant