Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DecompilerTask] remove monkey patching of task object #170

Closed
mm4rks opened this issue Jan 31, 2023 · 2 comments · Fixed by #344
Closed

[DecompilerTask] remove monkey patching of task object #170

mm4rks opened this issue Jan 31, 2023 · 2 comments · Fixed by #344
Assignees
@fnhartmann
Labels
feature-request New feature or request

Comments

@mm4rks
Copy link
Collaborator

mm4rks commented Jan 31, 2023

Proposal

In decompile.py:56 we use

task.code = self._backend.generate([task])

without task object having the .code property.

Same for decompiler/frontend/binaryninja/frontend.py:70:

task.function = function

Is this even needed?

Approach

Add property + getters / setters
@mm4rks mm4rks added the feature-request New feature or request label Jan 31, 2023
@mm4rks mm4rks mentioned this issue Jan 31, 2023
Merged
@fnhartmann fnhartmann self-assigned this Sep 27, 2023
@fnhartmann
Copy link
Collaborator

/cib

@github-actions
Copy link
Contributor

Branch issue-170-_DecompilerTask_remove_monkey_patching_of_task_object created!

github-actions bot pushed a commit that referenced this issue Sep 27, 2023
@fnhartmann
Create draft PR for #170
bc55aac
@github-actions github-actions bot mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnhartmann fnhartmann

Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DecompilerTask] remove monkey patching of task object fkie-cad/dewolf
2 participants
@mm4rks @fnhartmann