Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CExpressionGenerator] MemberAccess/Call on complex expression is missing parentheses #361

Closed
rihi opened this issue Nov 9, 2023 · 3 comments · Fixed by #372
Closed

[CExpressionGenerator] MemberAccess/Call on complex expression is missing parentheses #361

rihi opened this issue Nov 9, 2023 · 3 comments · Fixed by #372
Assignees
@rihi
Labels
bug Something isn't working priority-low Low priority issue

Comments

@rihi
Copy link
Collaborator

rihi commented Nov 9, 2023

When a member access happens on a complex expression like var + 1, the outputted c code is missing a parentheses like var + 1->member.

Relevant code: https://github.com/fkie-cad/dewolf/blob/0ff5502be6de63db3a8f5e023495e3d2a8c3a0ee/decompiler/backend/cexpressiongenerator.py#L168C1-L172
@rihi rihi added bug Something isn't working priority-low Low priority issue labels Nov 9, 2023
@rihi
Copy link
Collaborator Author

rihi commented Nov 22, 2023

This also seems to include Calls on expressions, like a + 1() should be (a +1)().

@rihi rihi changed the title [CExpressionGenerator] MemberAccess on complex expression is missing parentheses [CExpressionGenerator] MemberAccess/Call on complex expression is missing parentheses Nov 22, 2023
@rihi rihi self-assigned this Nov 30, 2023
@rihi
Copy link
Collaborator Author

rihi commented Nov 30, 2023

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch issue-361-_CExpressionGenerator_MemberAccess/Call_on_complex_expression_is_missing_parentheses created!

github-actions bot pushed a commit that referenced this issue Nov 30, 2023
@rihi
Create draft PR for #361
77804c4
@github-actions github-actions bot mentioned this issue Nov 30, 2023
Merged
rihi added a commit that referenced this issue Dec 6, 2023
@rihi
Create draft PR for #361
87cb8d8
0x6e62 pushed a commit that referenced this issue Dec 7, 2023
@github-actions @rihi
[CExpressionGenerator] MemberAccess/Call on complex expression is mis…
3c2ceae 
…sing parentheses (#372)

* Create draft PR for #361
* Fix incorrect braces on call/memberaccess

---------

Co-authored-by: rihi <[email protected]>
Co-authored-by: rihi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rihi rihi

Labels
bug Something isn't working priority-low Low priority issue
Projects
None yet
Milestone
No milestone
1 participant
@rihi