Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decoration] Exporting of rendered plots fails on windows #370

Merged

Conversation

github-actions[bot]
Copy link
Contributor

closes #369

@github-actions github-actions bot added bug Something isn't working priority-low Low priority issue labels Nov 29, 2023
@rihi rihi marked this pull request as ready for review November 29, 2023 14:48
@steffenenders steffenenders requested a review from blattm November 30, 2023 09:10
@rihi
Copy link
Collaborator

rihi commented Nov 30, 2023

Note, that the same issue theoretically exists for export_ascii aswell. However as far as I could see, graph-easy only reads input from files, so passing it via stdin is not possible.

@rihi
Copy link
Collaborator

rihi commented Nov 30, 2023

I think we could use in-memory "files" for the exporting tests. Then the tests don't have to interact with the filesystem. See https://docs.python.org/3/library/io.html#binary-i-o
Oh, sorry just realised that export_plot always writes to a file. Perhaps it would make sense to change the api of export_plot to allow specifying an output handle?

Copy link
Collaborator

@blattm blattm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

@blattm blattm enabled auto-merge (squash) December 7, 2023 12:14
@blattm blattm merged commit d66b606 into main Dec 7, 2023
1 check passed
@blattm blattm deleted the issue-369-_Decoration_Exporting_of_rendered_plots_fails_on_windows branch December 7, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-low Low priority issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Decoration] Exporting of rendered plots fails on windows
2 participants