Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"These set of vertices is not an identity group" #386

Closed
19h opened this issue Feb 19, 2024 · 2 comments
Closed

"These set of vertices is not an identity group" #386

19h opened this issue Feb 19, 2024 · 2 comments
Labels
bug Something isn't working priority-high High priority issue

Comments

@19h
Copy link

19h commented Feb 19, 2024

What happened?

[Default] [pipeline.py:112 run()] ERROR - Failed to decompile geo::codec::decodeLocalizations, error during stage identity-elimination: At least two variables in the identity group {x0_11#11 (type: char * aliased: False), x20#43 (type: char * aliased: False), x20#44 (type: char * aliased: False), x21#6 (type: char * aliased: False), x20#2 (type: char * aliased: False), x20#6 (type: char * aliased: False), x21#3 (type: char * aliased: False), x0_6#6 (type: char * aliased: False), x20#1 (type: char * aliased: False), x20#5 (type: char * aliased: False)} have out degree zero, namely x0_6#6 and x20#1, i.e., these set of vertices is not an identity group
[Default] [identity_elimination.py:225 find_replacement_variable_of_group()] ERROR - At least two variables in the identity group {x0_11#11 (type: char * aliased: False), x20#43 (type: char * aliased: False), x20#44 (type: char * aliased: False), x21#6 (type: char * aliased: False), x20#2 (type: char * aliased: False), x20#6 (type: char * aliased: False), x21#3 (type: char * aliased: False), x0_6#6 (type: char * aliased: False), x20#1 (type: char * aliased: False), x20#5 (type: char * aliased: False)} have out degree zero, namely x0_6#6 and x20#1, i.e., these set of vertices is not an identity group

I don't have a copy of the decompilation output but it essentially said "decompilation failed".

How to reproduce?

Load the file attached to #385 (comment) -- in this case I tried decompiling the function geo::codec::decodeLocalizations.

Affected Binary Ninja Version(s)

4.0.4886

@19h 19h added bug Something isn't working priority-high High priority issue labels Feb 19, 2024
@ebehner
Copy link
Collaborator

ebehner commented Feb 23, 2024

related to #135

@ebehner
Copy link
Collaborator

ebehner commented Feb 26, 2024

Fixed on current main (commit 50d6b52)

@ebehner ebehner closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-high High priority issue
Projects
None yet
Development

No branches or pull requests

2 participants