Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValueError@identity_elimination.py:278] ValueError: There are at least two definitions in the identity group var_58#0 = var_58#0 + (&(var_58#0)), var_58#0. #390

Closed
bugfinder-bot opened this issue Feb 26, 2024 · 2 comments · Fixed by #413
Closed

[ValueError@identity_elimination.py:278] ValueError: There are at least two definitions in the identity group var_58#0 = var_58#0 + (&(var_58#0)), var_58#0. #390

bugfinder-bot opened this issue Feb 26, 2024 · 2 comments · Fixed by #413
Assignees
@NeoQuix
Labels
bug Something isn't working bugfinder

Comments

@bugfinder-bot
Copy link
Collaborator

What happened?

  File "/opt/dewolf/decompiler/util/bugfinder/bugfinder.py", line 201, in iter_function_reports
    task_result = self.decompile(function, options)
  File "/opt/dewolf/decompile.py", line 51, in decompile
    pipeline.run(task)
  File "/opt/dewolf/decompiler/pipeline/pipeline.py", line 114, in run
    raise e
  File "/opt/dewolf/decompiler/pipeline/pipeline.py", line 107, in run
    instance.run(task)
  File "/opt/dewolf/decompiler/pipeline/dataflowanalysis/identity_elimination.py", line 313, in run
    variable_replacer.replace_variables(identity_group, identity_graph.find_replacement_variable_of_group(identity_group))
  File "/opt/dewolf/decompiler/pipeline/dataflowanalysis/identity_elimination.py", line 259, in replace_variables
    self._handle_definitions(replacees, replacement)
  File "/opt/dewolf/decompiler/pipeline/dataflowanalysis/identity_elimination.py", line 278, in _handle_definitions
    raise ValueError(message)

Error class ValueError@identity_elimination.py:278 contains 8 cases.

How to reproduce?

python decompile.py 4a89c3676dd86531c1fefb4e76d49cc31dc07a1a68c149dd08967e6fd7f6135a sub_438116 --debug

sample: 4a89c3676dd86531c1fefb4e76d49cc31dc07a1a68c149dd08967e6fd7f6135a
case: https://bugfinder.seclab-bonn.de/case/25759/
dewolf commit: b26c6ed
Binaryninja version: 3.5.4526
@bugfinder-bot bugfinder-bot added bug Something isn't working bugfinder labels Feb 26, 2024
@ebehner ebehner assigned ebehner and unassigned ebehner Feb 26, 2024
@NeoQuix NeoQuix self-assigned this Apr 29, 2024
@NeoQuix
Copy link
Collaborator

NeoQuix commented Jun 5, 2024

/cib

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Branch issue-390-ValueError_identity_elimination_py_278_ValueError_There_are_at_least_two_definitions_in_the_identity_group_var_58#0=var_58#0+_&_var_58#0_var_58#0 created!

github-actions bot added a commit that referenced this issue Jun 5, 2024
@github-actions
Create draft PR for #390
c614de9
@github-actions github-actions bot mentioned this issue Jun 5, 2024
Merged
@NeoQuix NeoQuix mentioned this issue Jun 5, 2024
Open
mari-mari pushed a commit that referenced this issue Jun 25, 2024
@github-actions @NeoQuix
[ValueError@identity_elimination.py:278] ValueError: There are at lea…
9647abc 
…st two definitions in the identity group var_58#0 = var_58#0 + (&(var_58#0)), var_58#0. (#413)

* Create draft PR for #390

* Fix+Test: *(&x)

* Mult. def test

---------

Co-authored-by: Spartak Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeoQuix NeoQuix

Labels
bug Something isn't working bugfinder
Projects
None yet
Milestone
No milestone
3 participants
@ebehner @NeoQuix @bugfinder-bot