Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lifter] Represent BNinja void correctly #415

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

closes #405

@github-actions github-actions bot added the feature-request New feature or request label Jun 11, 2024
@NeoQuix
Copy link
Collaborator

NeoQuix commented Jun 11, 2024

New: left | Old: right
image

@NeoQuix
Copy link
Collaborator

NeoQuix commented Jun 11, 2024

Note: In DeWolfs pseudo the code line using table_0 is actually &table_0, as given by bninja from the binary.
But again C syntax sugar at the backend eliminates the address operator.
(Don't like it but hey)

@blattm blattm self-requested a review June 13, 2024 09:10
@NeoQuix NeoQuix marked this pull request as ready for review June 19, 2024 07:30
Copy link
Collaborator

@blattm blattm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you :)

@blattm blattm enabled auto-merge (squash) June 24, 2024 11:42
@blattm blattm merged commit 2bd0591 into main Jun 24, 2024
1 check passed
@blattm blattm deleted the issue-405-_Lifter_Represent_BNinja_void_correctly branch June 24, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lifter] Represent BNinja void correctly
2 participants