Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False control structure for structs #342

Merged
merged 4 commits into from
Oct 9, 2023
Merged

False control structure for structs #342

merged 4 commits into from
Oct 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 21, 2023 •
edited by rihi
Loading

MediumLevelILVarField is an instruction, which only accesses parts of register like eax.ah. The current code would incorrectly lift this as eax & 0x0000FF00 even though it should be (uint8_t)(eax >> 8).

closes #256

@github-actions github-actions bot added bug Something isn't working priority-high High priority issue labels Sep 21, 2023
@rihi rihi self-assigned this Sep 22, 2023
@rihi rihi marked this pull request as ready for review September 22, 2023 10:44
@steffenenders steffenenders self-requested a review October 5, 2023 08:38
@steffenenders steffenenders merged commit 9663023 into main Oct 9, 2023
1 check passed
@steffenenders steffenenders deleted the issue-256-False_control_structure_for_structs branch October 9, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenenders steffenenders Awaiting requested review from steffenenders

Assignees

@rihi rihi

Labels
bug Something isn't working priority-high High priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False control structure for structs
2 participants
@steffenenders @rihi