New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling empty strings in MQTT environment variables + not set attributes #202

Open

coconup wants to merge 1 commit into fl4p:master from coconup:240219-env_vars

coconup commented Feb 19, 2024

Accepting empty strings (e.g. MQTT_USER / MQTT_PASSWORD) as environment variables
Avoiding errors if mqtt_user is not set in user_config


          handling empty strings in environment variables + case when some vars…

77159cf

… are not set

Owner

fl4p commented Dec 10, 2024

Skipping empty env values was intentionally.
It looks like you want to override user_config with empty env values?

I propose this change:

if env_value is not None or k not in user_config:

becomes:

if env_value is not None and k not in user_config:

The env value should not be used if it is None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet