New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTCP PING reply MUST contain exactly the same parameters as the original query #432

Open

normanr opened this issue Mar 11, 2019 · 0 comments

normanr commented Mar 11, 2019

ref: https://tools.ietf.org/id/draft-oakley-irc-ctcp-01.html#ping

circ/package/bin/irc/ctcp_handler.js

Line 86 in c148289

return [' ' + args[0]];

should be

return [' ' + args.join(' ')];

ohfunc mentioned this issue

Have CTCP PING reply with the exact same parameters as the request #436

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment