Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need RBAC Permissions for Deployment Creation and Deletion #2308

Closed
christianshub opened this issue Oct 30, 2024 · 1 comment
Closed

Need RBAC Permissions for Deployment Creation and Deletion #2308

christianshub opened this issue Oct 30, 2024 · 1 comment

Comments

@christianshub
Copy link
Contributor

christianshub commented Oct 30, 2024

Description

To expand the testing capabilities of Canary Checker, it is necessary to allow the creation and deletion of Kubernetes deployments. This enhancement would enable users to perform deployment tests as part of their canary checks, ensuring the health and functionality of deployments in real-time.

Problem Statement

Currently, Canary Checker lacks RBAC permissions to create and delete deployments, limiting its ability to perform comprehensive deployment-related health checks. As a result, users are unable to test deployment scenarios directly through Canary Checker without manually adding rbac rules.

Proposed Solution

Add a new option, deploymentCreateAndDelete, in values.yaml to control the RBAC permissions for deployments. When enabled, this option will grant Canary Checker create and delete permissions for deployments in the apps API group as a minimum.

Benefits

  • Enhances Canary Checker’s capabilities by supporting deployment-based tests.
  • Provides flexibility to users who want to validate deployment availability, recreate deployments, and ensure resilient deployment behavior.
  • Improves monitoring and validation coverage for applications managed within Kubernetes.

Acceptance Criteria

  • deploymentCreateAndDelete setting is available in values.yaml.
  • Canary Checker can successfully create and delete deployments when the setting is enabled.
  • Documentation is updated to inform users about the new option and its use cases.

PR with suggested changes: #2307

@christianshub
Copy link
Contributor Author

Merged in #2307. Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant