From 82d3db732707e90444a4bbd8968560a8a1bc8bad Mon Sep 17 00:00:00 2001
From: Davide Iadeluca <davide.iadeluca@glowingblue.com>
Date: Fri, 15 Nov 2024 12:09:46 +0100
Subject: [PATCH] chore: add accessible label to scope removal button

---
 framework/core/js/src/admin/components/PermissionGrid.tsx | 7 ++++++-
 framework/core/locale/core.yml                            | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/framework/core/js/src/admin/components/PermissionGrid.tsx b/framework/core/js/src/admin/components/PermissionGrid.tsx
index 76ae8d1cb7..39d9cfbb64 100644
--- a/framework/core/js/src/admin/components/PermissionGrid.tsx
+++ b/framework/core/js/src/admin/components/PermissionGrid.tsx
@@ -57,7 +57,12 @@ export default class PermissionGrid<CustomAttrs extends IPermissionGridAttrs = I
               <th>
                 {scope.label}{' '}
                 {!!scope.onremove && (
-                  <Button icon="fas fa-times" className="Button Button--text PermissionGrid-removeScope" onclick={scope.onremove} />
+                  <Button
+                    icon="fas fa-times"
+                    className="Button Button--text PermissionGrid-removeScope"
+                    aria-label={app.translator.trans('core.admin.permissions.remove_scope_label', { scope: scope.label })}
+                    onclick={scope.onremove}
+                  />
                 )}
               </th>
             ))}
diff --git a/framework/core/locale/core.yml b/framework/core/locale/core.yml
index 7808c5d0aa..2b3924839d 100644
--- a/framework/core/locale/core.yml
+++ b/framework/core/locale/core.yml
@@ -226,6 +226,7 @@ core:
       participate_heading: Participate
       post_without_throttle_label: Reply multiple times without waiting
       read_heading: Read
+      remove_scope_label: Remove scope of {scope}
       rename_discussions_label: Rename discussions
       reply_to_discussions_label: Reply to discussions
       search_users_label: => core.ref.search_users