From 92b2b4aad11a756bc225441b1482928002c436cc Mon Sep 17 00:00:00 2001
From: Davide Iadeluca <146922689+DavideIadeluca@users.noreply.github.com>
Date: Tue, 22 Oct 2024 11:14:06 +0200
Subject: [PATCH] [1.x] chore: resolve node deprecation warnings in workflows
 (#4081)

* chore: update frontend workflow

Backport of https://github.com/flarum/framework/commit/356f97641ed8d087dd1252e4cc2180484d8590cd

* chore: bump default node version and `flarum/action-build`

* fix

* dummy commit
---
 .github/workflows/REUSABLE_frontend.yml | 9 +++++----
 js-packages/tsconfig/tsconfig.json      | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/REUSABLE_frontend.yml b/.github/workflows/REUSABLE_frontend.yml
index f6a9d7d1bb..dbb5988fdb 100644
--- a/.github/workflows/REUSABLE_frontend.yml
+++ b/.github/workflows/REUSABLE_frontend.yml
@@ -74,7 +74,7 @@ on:
         description: The node version to use for the workflow.
         type: number
         required: false
-        default: 16
+        default: 20
 
       js_package_manager:
         description: "Enable TypeScript?"
@@ -105,6 +105,7 @@ env:
   ci_script: ${{ inputs.js_package_manager == 'yarn' && 'yarn install --immutable' || 'npm ci' }}
   cache_dependency_path: ${{ inputs.cache_dependency_path || format(inputs.js_package_manager == 'yarn' && '{0}/yarn.lock' || '{0}/package-lock.json', inputs.frontend_directory) }}
   COMPOSER_AUTH: ${{ secrets.composer_auth }}
+  DISABLE_V8_COMPILE_CACHE: 1
 
 jobs:
   build:
@@ -116,10 +117,10 @@ jobs:
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ inputs.node_version }}
           cache: ${{ inputs.js_package_manager }}
@@ -142,7 +143,7 @@ jobs:
         working-directory: ${{ inputs.frontend_directory }}
 
       - name: JS Checks & Production Build
-        uses: flarum/action-build@v3
+        uses: flarum/action-build@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           build_script: ${{ inputs.build_script }}
diff --git a/js-packages/tsconfig/tsconfig.json b/js-packages/tsconfig/tsconfig.json
index 92bc9ec883..7ad380af48 100644
--- a/js-packages/tsconfig/tsconfig.json
+++ b/js-packages/tsconfig/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "skipLibCheck": true,
     "allowUmdGlobalAccess": true,
     "sourceMap": true,
     "strict": true,