Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock notification says "locked" even when the discussion is unlocked #2

Open
matteocontrini opened this issue Mar 1, 2022 · 0 comments

Comments

@matteocontrini
Copy link

Bug Report

Current Behavior

Currently when you lock a discussion the web notification that is generated says "{user} locked".

The text is the same even if the admin/mod actually unlocked the discussion.

https://github.com/flarum/lock/blob/c4383c318899fce6d5e7c936695edbe5f7f49c88/locale/en.yml#L28

Steps to Reproduce

  1. Lock a discussion
  2. Notice the text of the notification delivered to the discussion author

Expected Behavior

I think the notification text should distinguish between locked/unlocked.

Environment

  • Flarum version: 1.2.0

Possible Solution

The notification data should include whether the action is lock or unlock, in order to expose that information to the client.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant