Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flarum-cli audit infra #27

Open
askvortsov1 opened this issue Oct 14, 2021 · 3 comments
Open

flarum-cli audit infra #27

askvortsov1 opened this issue Oct 14, 2021 · 3 comments
Assignees

Comments

@askvortsov1
Copy link
Member

Feature Request

There is a LOT of repo infra / config that can easily get out of date:

  • GitHub action scripts
  • TypeScript config
  • Automated testing config
  • (hopefully) PHPStan config

Because of Flarum's many-extension architecture, there are also a LOT of repos to keep track of / keep up to date. This is tedious and not scalable.

I believe we should use flarum-cli as the single source of truth for all this repo infrastructure. We can store the "proper" config via the boilerplate extension, and the infra commands that automatically update parts of extension skeletons. Then, a flarum audit infra command can be used to check whether any infra is out of date / not in compliance with our opinionated specs.

Furthermore, we can add a GItHub action to every Flarum repo that runs flarum-cli infra audit to see whether anything is out of date. This will make it really easy to keep Flarum repo infra up to date.

@tankerkiller125
Copy link

The other option would be to make all of the GitHub actions infrastructure Github Action packages, (I think you can do that) thus updating one package updates everything across our entire organization, similar to the way that our JS build action works.

@askvortsov1
Copy link
Member Author

The other option would be to make all of the GitHub actions infrastructure Github Action packages, (I think you can do that) thus updating one package updates everything across our entire organization, similar to the way that our JS build action works.

We'd still need to bump versions across all repos, plus that doesn't help with typescript config, testing, etc.

@tankerkiller125
Copy link

Fair enough

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants